3 comments (3 comments)0 reactions (0 reactions)0 assignees (0 assignees)C++5,373 forks (5,373 forks)batch import
area/health_checkingenhancementhelp wanted
Repository metrics
- Stars
- 27,997 stars (27,997 stars)
- PR merge metrics
- Avg merge 8d (Avg merge 8d)378 merged PRs in 30d (378 merged PRs in 30d)
Description
Title: Improve health status logging on envoy
Description:
On envoy HealthCheckEjectUnhealthy() will only emit HealthCheckFailureType (ACTIVE (DEFAULT) , PASSIVE, NETWORK, NETWORK_TIMEOUT). It would be nice to have the option for more verbose logs such as http status codes.
Contributor guide
- Research direction
- The issue requests adding HTTP status codes to health check failure logs. The relevant file is api/envoy/data/core/v3/health check event.proto where HealthCheckEjectUnhealthy emits HealthCheckFailureType. Investigate how the failure type is currently logged and where to add an optional HTTP status code field. Check the existing 3 comments for additional context. Consider extending the protobuf definition and updating the logging logic in the health checker implementation.
- Tech stack
- cpp
- Domain
- observability
- Issue type
- Feature
- Prerequisites
- C++Protocol BuffersEnvoy health check eventsHTTP status codes