envoyproxy/envoy

xds: extend GoogleGrpcService with TLS version conditions

Open

#32,554 opened on Feb 23, 2024

View on GitHubContributor guide
 (1 comment) (1 reaction) (0 assignees)C++ (5,373 forks)batch import
area/grpcarea/tlsenhancementhelp wanted

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Follow-up to #32315 to add fields to google_grpc to support setting minimum and maximum TLS versions explicitly. Note this has impact on Wasm ABI, since this proto is used to make RPCs.

cc @htuch

Contributor guide

Research direction
Add min tls version and max tls version fields to the GoogleGrpcService proto in api/envoy/extensions/transport sockets/tls/v3/common.proto, update the xDS configuration handling in source/common/grpc/google grpc service.cc, and ensure Wasm ABI compatibility. Refer to PR #32315 for context and the existing pattern for TLS version fields.
Tech stack
None
Domain
backendapisecurity
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
GitUnderstanding of Envoy architectureTLS basicsProtobuf
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50