envoyproxy/envoy

cleanup: add proto definition for test extensions

Closed

#20,476 opened on Mar 23, 2022

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)C++ (5,373 forks)batch import
area/protobufbeginnerbughelp wantedtech debt

Repository metrics

Stars
 (27,997 stars)
PR merge metrics
 (Avg merge 8d) (378 merged PRs in 30d)

Description

Currently, lookup-by-name for extensions is used for internal extensions. This is inconsistent with actual extensions which exclusively use lookup-by-type-URL. The cleanup is to add protos for all internal extensions, and remove the runtime guard usage in the tests.

Contributor guide

Research direction
Investigate the existing internal extensions in 'source/extensions/' directory. Examine proto definitions for external extensions (e.g., 'api/envoy/extensions/') to understand the pattern. Find all uses of lookup by name and runtime guards in test files. The goal is to add proto definitions for each internal extension and refactor tests to use lookup by type URL. Refer to any comments or linked PRs in issue #20476 for additional context.
Tech stack
cpp
Domain
backendinfrastructure
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++ knowledgeProtocol BuffersEnvoy internalsTesting experience
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30