emberjs/ember.js

Document the order of Splattributes, {{on}} modifier and component event handlers

Open

#17,877 opened on Apr 7, 2019

View on GitHubContributor guide
 (8 comments) (0 reactions) (0 assignees)JavaScript (4,216 forks)batch import
documentationgood first issue

Repository metrics

Stars
 (22,437 stars)
PR merge metrics
 (Avg merge 11d 14h) (20 merged PRs in 30d)

Description

See https://github.com/emberjs/ember.js/pull/17874#discussion_r272809665

As part of the fix we need to decide which one fires first, since it was not specified in the RFC. My gut feeling is that the component’s handler should fire first and given the option to cancel it.

Contributor guide

Research direction
Investigate the RFC and the linked discussion to determine the order of event firing for component handlers vs modifiers.
Tech stack
javascript
Domain
frontend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70