emberjs/ember-test-helpers

Input events should be instantiated with `{ composed: true }`

Open

#1,201 opened on Mar 3, 2022

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)JavaScript (256 forks)github user discovery
enhancementgood first issue

Repository metrics

Stars
 (188 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The composed property determines whether an event that occurs in shadow DOM will bubble to the host element.

Link to MDN docs.

In HTML, all form control input events are composed 1 2.

Presently, we are not instantiating input events with { composed: true }. See for example fillIn and select. I have not looked if there are other places. It probably makes sense to make this change in fireEvent itself similar to how bubbles is true by default.

Footnotes

  1. Search for "Fire an event named input" on https://html.spec.whatwg.org/multipage/input.html and https://html.spec.whatwg.org/multipage/form-elements.html. ↩

  2. Change events are not composed. ↩

Contributor guide

Research direction
Inspect the fireEvent function and add `{ composed: true }` to event initialization options, similar to how `bubbles: true` is set by default. Then ensure all input related event calls are updated accordingly.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75