emacs-jupyter/jupyter

REPL return hangs with imatlab kernel

Open

#165 opened on Aug 5, 2019

View on GitHubContributor guide
 (6 comments) (0 reactions) (0 assignees)Emacs Lisp (106 forks)auto 404
REPLbughelp wanted

Repository metrics

Stars
 (1,028 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I've been using imatlab with emacs Jupyter for about 2 months now. For some reason, the REPL-return now hangs with v0.8.1 and the current master. A quick profiler report indicates that it is getting stuck in the ring-insert function, specifically associated with the REPL history add function. I did a quick git bisection and narrowed the bug being introduced in commit 49275c37b844b7e8a07d9f15d5eefbbdeda1f76e, but it's not clear to me what went wrong.

Contributor guide

Research direction
Investigate the ring insert function and the REPL history add function. Review the changes in commit 49275c37b844b7e8a07d9f15d5eefbbdeda1f76e that introduced the bug. Run a test with a MATLAB kernel to reproduce the hang and trace where the function loops indefinitely.
Tech stack
None
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Emacs Lisp
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50