electerious/basicScroll

Remove environment warning

Open

#59 opened on Sep 10, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (146 forks)batch import
help wanted

Repository metrics

Stars
 (3,599 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Hi, first of all - great plugin!

I've set it up and everything works great, but when I run gulp I get the warning "basicScroll is not executing because you are using it in an environment without a window object".

I'm a bit of a rookie so this could be something I have done. I've searched the error and similar errors on Google but couldn't find a fix. Any ideas?

Contributor guide

Research direction
Find the line in the source code where the warning is logged (likely using console.warn). Understand the condition that triggers it and evaluate whether it can be removed or changed to a less intrusive message.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85