elastic/logstash

Delete batch files from deb (and rpm) packages

Open

#2,844 opened on Mar 18, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Ruby (3,496 forks)batch import
buggood first issuehacktoberfestpackaging

Repository metrics

Stars
 (14,197 stars)
PR merge metrics
 (Avg merge 4d 15h) (51 merged PRs in 30d)

Description

I noticed on my Linux system, when using the package that it is also installing .bat files (for Windows) along with the bash scripts to run the script.

Here is a patch that should take care of removing them before building the package (untested):

diff --git a/pkg/build.sh b/pkg/build.sh
index 8ad876b..0d56ab4 100755
--- a/pkg/build.sh
+++ b/pkg/build.sh
@@ -41,6 +41,9 @@ fi

 tar -C $destdir/$prefix --strip-components 1 -zxpf $tar

+# Delete batch files
+rm -f $destdir/opt/logstash/bin/*.bat
+
 case $os@$release in
  centos@*|fedora@*|el6@*|sl6@*)
     mkdir -p $destdir/etc/logrotate.d

Contributor guide

Research direction
Check if the .bat files are still included in the Linux packages by building Logstash locally using the scripts in pkg/build.sh. If the issue persists, apply the provided patch and test the build for both deb and rpm packages. Also, review the git history to see if this fix was already implemented in a later commit.
Tech stack
shell
Domain
devops
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
basic shell scripting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85