elastic/logstash

add file locking to prevent concurrent access to Gemfile from plugin manager

Open

#2,622 opened on Feb 16, 2015

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Ruby (3,496 forks)batch import
bundlerenhancementhelp wantedplugin manager

Repository metrics

Stars
 (14,197 stars)
PR merge metrics
 (Avg merge 4d 19h) (50 merged PRs in 30d)

Description

in lib/logstash/gemfile.rb per #2475 discussion

Contributor guide

Research direction
Inspect the current Gemfile.rb implementation and understand the concurrent access scenario from the plugin manager. Review the discussion in issue #2475 for context. Implement file locking using Ruby's File.flock or similar to ensure mutual exclusion when reading/writing the Gemfile.
Tech stack
ruby
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75