elastic/kibana

[APM] Storage explorer should display sampling rate as N/A if there are no tx

Closed

#150,302 opened on Feb 6, 2023

View on GitHubContributor guide
 (5 comments) (0 reactions) (0 assignees)TypeScript (8,021 forks)batch import
Team:obs-ux-infra_services - DEPRECATEDapm:storage-explorerbuggood first issue

Repository metrics

Stars
 (19,065 stars)
PR merge metrics
 (Avg merge 1d 16h) (999 merged PRs in 30d)

Description

Currently, the Storage Explorer displays a sampling rate of 0% if there are no transactions. This is misleading, as we can't actually infer what the sampling rate would be if there were transactions (which might not exist or might be dropped for whatever reason). We should instead display N/A. This would help the user (and us in the context of SDHs) establish more quickly that there are no transactions indexed into Elasticsearch.

https://github.com/elastic/kibana/blob/main/x-pack/plugins/apm/server/routes/storage_explorer/get_service_statistics.ts

Contributor guide

Research direction
In the file `x pack/plugins/apm/server/routes/storage explorer/get service statistics.ts`, find where the sampling rate is set to '0%' and change it to 'N/A' when there are no transactions.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85