elastic/apm-agent-java

Add support for SimpleAsyncUncaughtExceptionHandler to capture exceptions with Spring web mvc

Open

#2,218 opened on Oct 29, 2021

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Java (332 forks)auto 404
agent-javaenhancementgood first issuesize:small

Repository metrics

Stars
 (592 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem?

An error was not captured in APM

  • Spring web mvc > HTTP request > Spring web mvc framework > thread call(async)

APM debug logs

"....SimpleAsyncUncaughtExceptionHandler : Unexpected error occurred invoking async method: public void ..."
"Oct 25, 2021 @ 14:40:23.893","java.lang.Exception: null"
"Oct 25, 2021 @ 14:40:23.893","	at 
... (trace not relevant)

Describe the solution you'd like

The error is captured and visible in APM, with no stack traces in the logs

Describe alternatives you've considered

None

Additional context

None

Contributor guide

Research direction
Examine the existing exception capture mechanism in the APM agent, identify how to intercept or wrap SimpleAsyncUncaughtExceptionHandler, and implement a custom handler that forwards exceptions to the APM agent.
Tech stack
javaspring
Domain
backendapiobservability
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaSpringAPM agent fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60