eduaguilera/whep

spatialize: dead helpers .normalize_to_cropland and .get_area_code_from_grid

Open

#225 opened on Jul 22, 2026

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)R (3 forks)auto 404
area:spatializeclean codegood first issuehelp wantedmechanicalno-data-neededpriority:low

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

What

.normalize_to_cropland (R/spatialize.R:924) and .get_area_code_from_grid (:633) are defined but never called anywhere in R/ or tests/. Also type_count <- dplyr::n_distinct(...) (:199) is computed and immediately discarded (comment implies a message was intended but none is emitted).

Suggested fix / check

Remove the dead helpers and the unused computation (or wire up the intended message).

From deep static audit (2026-07-22), parallel subsystem review pass. Deduplicated against then-open issues. Not verified by running unless stated.

Contributor guide

Research direction
Search the entire repository including R/ and tests/ to confirm that .normalize to cropland and .get area code from grid are never called. Also verify the unused type count variable. Then remove the dead code, and if an intended message exists, wire it up or remove it as well.
Tech stack
r
Domain
data
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitR
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80