eduaguilera/whep

feed_intake_build: dead columns computed and joined in .build_feed_demand

Open

#222 opened on Jul 22, 2026

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)R (3 forks)auto 404
area:livestockclean codegood first issuehelp wantedmechanicalno-data-neededpriority:low

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

What

In .build_feed_demand (R/feed_intake_build.R:204-209), demand_tot and demand_share are computed per (year, area_code, feed_type) and .feed_animal_type_lookup (graniv_grazers) is joined, but the sole consumer .build_feed_demand_codes (R/feed_intake_redistribute.R:398-401) reads only demand_aft. These are dead.

Why it matters

Harmless, but demand_share = demand_aft / (demand_tot * 1000) (with demand_tot itself pre-divided by 1000) is an error-prone expression a future reader could misuse.

Suggested fix / check

Remove the unused columns and lookup join.

From deep static audit (2026-07-22), parallel subsystem review pass. Deduplicated against then-open issues. Not verified by running unless stated.

Contributor guide

Research direction
Inspect the code in R/feed intake build.R (lines 204-209) and R/feed intake redistribute.R (lines 398-401) to confirm the unused columns and the lookup join. Remove the dead columns and the join, then run the existing tests to ensure nothing breaks.
Tech stack
r
Domain
data
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80