dtolnay/cxx

Figure out where to put #[inline]

Open

#146 opened on Apr 25, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Rust (253 forks)batch import
help wanted

Repository metrics

Stars
 (4,472 stars)
PR merge metrics
 (Avg merge 8m) (3 merged PRs in 30d)

Description

In the Rust code generator we currently emit some shims that do nothing more than cast between smart pointers and raw pointers and then dispatch to the appropriate extern "C" function.

These shims should probably be marked #[inline] so that callers are able to directly call the extern "C" function themselves, but ideally I'd like at least one performance measurement showing a benefit before going forward with the change.

Contributor guide

Research direction
Measure the performance impact of adding #[inline] to the shims in the Rust code generator. Test with a benchmark that exercises the interop layer and compare with and without the attribute.
Tech stack
rust
Domain
compilers
Issue type
Performance
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Rust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60