dthree/vorpal

Hitting CTRL+C while in Inquirer prompt breaks everything

Open

#42 opened on Nov 1, 2015

View on GitHub
 (16 comments) (0 reactions) (0 assignees)JavaScript (277 forks)batch import
bughelp wanted

Repository metrics

Stars
 (5,626 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The output looks like this:

(^C again to quit)
function (str) {
  if (str === undefined) {
    return this._delimiter;
  }
  this._delimiter = String(str).trim() + ' ';
  if (this.isLocal()) {
    this.parent.ui.refresh();
  } else {
    this.parent._send('vantage-delimiter-downstream', 'downstream', {value: str, sessionId: this.id});
  }
  return this;
}
_

You can still type but nothing happens. Only way to recover is hitting CTRL+C again.

Contributor guide

Research direction
Investigate how the CTRL+C signal is handled in the Inquirer prompt and Vorpal's event loop. Look at the keypress listener and the cleanup mechanism.
Tech stack
javascriptnodejs
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70