dry-rb/dry-validation

Add key.success? and key.failure? predicates

Open

#615 opened on Jan 15, 2020

View on GitHubContributor guide
 (12 comments) (0 reactions) (0 assignees)Ruby (196 forks)github user discovery
featurehelp wanted

Repository metrics

Stars
 (1,422 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In complex rules, it may be useful to know whether the key has any failure message already.

rule(:foos).each do
  key.success? # => true
  key.failure? # => false
  key.failure('wrong')
  key.success? # => false
  key.failure? # => true
end

Contributor guide

Research direction
Investigate the Key class in dry validation to understand where to add the success? and failure? methods and ensure they reflect the current state.
Tech stack
ruby
Domain
backend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70