dragonflydb/dragonfly

refactor DbSlice::ExpireParams

Closed

#3,634 opened on Sep 3, 2024

View on GitHubContributor guide
 (13 comments) (0 reactions) (1 assignee)C++ (1,177 forks)batch import
good first issue

Repository metrics

Stars
 (30,465 stars)
PR merge metrics
 (Avg merge 2d 11h) (201 merged PRs in 30d)

Description

we have several fields in DbSlice::ExpireParams: int64_t value = INT64_MIN; // undefined TimeUnit unit = TimeUnit::SEC; bool absolute = false;

All these fields can be exchanged with one int64_t ms_timestamp, that will be created in the constructor or method.

Contributor guide

Research direction
Examine the current DbSlice::ExpireParams struct in the source files to understand how 'value', 'unit', and 'absolute' fields are used. Then, replace these fields with a single 'int64 t ms timestamp' that is computed in the constructor or a method. Ensure all references are updated and tests pass. Review any comments or linked discussions for additional context.
Tech stack
cpp
Domain
database
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++ basicsFamiliarity with DbSlice
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60