dotnet/wpf

Avoid calling Path.GetTempFileName

Open

#259 opened on Jan 11, 2019

View on GitHubContributor guide
 (3 comments) (3 reactions) (0 assignees)C# (1,126 forks)batch import
:construction: work in progressEnhancement RequestedGood First Issue

Repository metrics

Stars
 (6,683 stars)
PR merge metrics
 (Avg merge 2d 7h) (41 merged PRs in 30d)

Description

System.Windows.Input.Cursor.LoadFromStream may throw IOException. DevDiv\FX\Rel\Net471Rel1Last\wpf\src\Core\CSharp\System\Windows\Input\Cursor.cs calls Path.GetTempFileName which will throw if the %TEMP% directory contains too many temp files (65k).

Reported by customer as VS Feedback issue

Contributor guide

Research direction
Replace the usage of Path.GetTempFileName with a safer alternative like Path.GetTempPath() combined with generating a unique filename using Guid or similar, to avoid the IOException caused by exceeding the maximum number of temporary files (65k) in the %TEMP% directory.
Tech stack
csharp
Domain
desktop
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70