dotnet/runtime

`GetTypeByMetadataName` should be banned

Open

#72,336 opened on Jul 17, 2022

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-Metahelp wanted

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

See https://github.com/dotnet/runtime/issues/57349 for details. There are currently usages of this API, these should be replaced with GetBestTypeByMetadataName and also BannedApiAnalyzers should be used to prevent any accidental future usages.

Contributor guide

Research direction
Identify all usages of GetTypeByMetadataName in the codebase and replace them with GetBestTypeByMetadataName. Then, configure BannedApiAnalyzers to prevent future usage.
Tech stack
csharp
Domain
developer experience
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70