dotnet/runtime

SerialPort timeout tests are slow and flaky

Open

#20,149 opened on Feb 8, 2017

View on GitHubContributor guide
 (15 comments) (0 reactions) (0 assignees)C# (5,445 forks)batch import
area-System.IO.Portsdisabled-testhelp wantedtest-bug

Repository metrics

Stars
 (17,886 stars)
PR merge metrics
 (Avg merge 12d 11h) (661 merged PRs in 30d)

Description

They don't play well with CI builds and take some time.

We need to:

  1. Pick some more generous thresholds for validation
  2. Try to make tests faster where possible
  3. Move the slowest tests to the outer loop

dotnet/runtime#20091

Contributor guide

Research direction
Examine the failing SerialPort timeout tests, adjust thresholds to be more generous, optimize test execution speed, and relocate the slowest tests to the outer test loop.
Tech stack
csharp
Domain
testing qa
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65