dotnet/roslyn

Possibly incorrect comment in definite assignment

Open

#62,522 opened on Jul 9, 2022

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugConcept-Design Debthelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

https://github.com/dotnet/roslyn/blob/7fc34f9e211bef9499cd1bdf6a11630f12052de1/src/Compilers/CSharp/Portable/FlowAnalysis/DefiniteAssignment.cs#L1684

commenting out the code fails the test PiecewiseStructAssign2 with definite assignment errors. So it has more effect than region analysis APIs.

Contributor guide

Research direction
Inspect the comment at line 1684 in DefiniteAssignment.cs. Remove the comment and run the test PiecewiseStructAssign2 to verify if the comment is incorrect. Trace the definite assignment logic to understand its effect on region analysis APIs.
Tech stack
csharp
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25