dotnet/roslyn

csc and vbc don't detect recursive response files

Open

#5,874 opened on Oct 11, 2015

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

As a simple repro, create a minimal response file, test.rs, which just refers to itself:

@test.rs

Now run vbc @test.rs or csc @test.rs and observe what appears to be an infinite loop (1 CPU core spins at 100% and memory usage grows unchecked).
The native compilers (version 4.6.0081.0 on my machine) under Windows\Microsoft.NET\Framework detect when a response file is specified multiple times, recursively or otherwise, and show an error (although the native vbc subsequently crashes).

Contributor guide

Research direction
Examine the response file parser in Roslyn's command line compiler to implement recursion detection and error reporting similar to native compilers.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#compiler basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40