dotnet/roslyn

Missing test case for conditional access in `CheckValEscape`

Open

#57,653 opened on Nov 9, 2021

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

https://github.com/dotnet/roslyn/pull/57050#discussion_r726383228 adds a test case that hits a conditional access receiver in Binder.GetValEscape. This suggests that CheckValEscape should also be able to see this node in an error scenario, like GetValEscape, but we don't have a test case covering this so we haven't added it to the switch there. We should investigate to see if a test case can be created where that node is hit in CheckValEscape as well.

Contributor guide

Research direction
Examine the existing test and GetValEscape implementation to understand how the conditional access node is hit. Then attempt to create a scenario where CheckValEscape encounters the same node.
Tech stack
csharp
Domain
testing
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#TestingGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75