dotnet/roslyn

#if has same scope as other directive in C# scripting

Open

#57,467 opened on Oct 29, 2021

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersArea-InteractiveBughelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

ITNOA

Version Used: Latest version

Steps to Reproduce:

As you can see https://github.com/cake-build/cake/issues/1766#issuecomment-333958357, If you write below code

#if (FOO)
#r ".\Newtonsoft.Json.dll"
#endif


Console.WriteLine(
    Newtonsoft.Json.JsonConvert.SerializeObject(
            new {
                Hello = "World"
            }
        )
    );

Expected Behavior: Load Newtonsoft.Json.dll if FOO is defined, otherwise Newtonsoft.Json.dll must not be load

Actual Behavior: it works regardless #if define FOO or not, so would seem as #r is processed at same scope as #if/#define

Contributor guide

Research direction
Investigate how #r directives are processed in relation to #if preprocessor directives in the C# scripting engine. Look at the lexer and parser for preprocessor handling.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20