dotnet/roslyn

Lifted relational operators returning true should inform nullability tracking that neither operand can be null

Open

#56,517 opened on Sep 18, 2021

 (1 comment) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugFeature - Nullable Reference Typeshelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

Version Used: 17.0.0-p4.0

These two CS8629 diagnostics should not be generated:

#nullable enable

using System;

class C
{
    void M(DateTime? a, DateTime? b)
    {
        if (a < b) // If this is true, neither variable can be null
        {
            // ⚠ CS8629 Nullable value type may be null.
            //  ↓
            _ = a.Value;
            //  ↓
            _ = b.Value;
        }
    }
}

https://docs.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/expressions#lifted-operators:

For the relational operators < > <= >=, [...t]he lifted operator produces the value false if one or both operands are null.

Contributor guide