dotnet/roslyn

Override Equals in subtypes of DiagnosticInfo

Open

#4,786 opened on Aug 25, 2015

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)C# (4,257 forks)batch import
Area-CompilersBugConcept-Continuous Improvementhelp wanted

Repository metrics

Stars
 (20,414 stars)
PR merge metrics
 (Avg merge 6d 17h) (256 merged PRs in 30d)

Description

For example, DiagnosticInfoWithSymbols introduces a Symbols field that is not considered by DiagnosticInfo.Equals.

Contributor guide

Research direction
Identify all subtypes of DiagnosticInfo that introduce new fields and override Equals and GetHashCode accordingly.
Tech stack
csharp
Domain
compilers
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80