dotnet/command-line-api

GetCompletions should check exit code of invoked application

Open

#2,137 opened on Mar 31, 2023

View on GitHub
 (1 comment) (3 reactions) (0 assignees)C# (421 forks)auto 404
Area-Completionsbughelp wanted

Repository metrics

Stars
 (3,665 stars)
PR merge metrics
 (Avg merge 1h 58m) (1 merged PR in 30d)

Description

This code should probably check the exit code and not consider standard output to be completions when it is non-zero:

https://github.com/dotnet/command-line-api/blob/403234a4c4247151d09073bc07ccc13530ce62c6/src/System.CommandLine.Suggest/SuggestionStore.cs#L47-L50

cc @jonsequitur @adamsitnik

Contributor guide

Research direction
Modify the method to check the exit code of the invoked application and handle non zero exit codes appropriately.
Tech stack
csharp
Domain
cli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C#Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80