dolthub/dolt

`ExistingRefError.Error()` omits the ref name and type

Open

#11,434 opened on Aug 6, 2026

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (429 forks)batch import
bad error messagegood first issueversion control

Repository metrics

Stars
 (15,227 stars)
PR merge metrics
 (Avg merge 2d 21h) (58 merged PRs in 30d)

Description

doltdb.ExistingRefError is returned when a caller-provided name collides with an existing ref. Its Error() explicitly returns a "already exists", a bare string.

https://github.com/dolthub/dolt/blob/56fc3f4f292598b644df4397d5ef1799a5883c07/go/libraries/doltcore/doltdb/errors.go#L158-L162

The type carries a Ref field that identifies the conflict. Branch creation already recovers this detail out of band, but tag and workspaces do not.

Error() should include the ref, for example: ref 'refs/heads/x' already exists. Updating 'Error()` will change the message tag and workspace callers and test assert against, so they'll have to be updated with their own wrappers.

Contributor guide

Research direction
Inspect the `ExistingRefError` type in `go/libraries/doltcore/doltdb/errors.go`. Note that `Error()` returns a generic message. Search for all usages of `ExistingRefError` in the codebase, especially in tag and workspace workflows, and identify the tests that assert on the current error message. Determine how to include the `Ref` field in the error string while keeping the change minimal.
Tech stack
go
Domain
backenddatabase
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GoGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80