digital-york/oasis

Upload form unexpected on-click behaviour: Journal of publication - other option field

Open

#277 opened on Feb 16, 2019

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Ruby (0 forks)auto 404
Priority - mediumUIbuggood first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

How to reproduce this issue

Navigate to Journal of publication field in upload form. An other option need to be used twice in order to make an additional text area appear:

  • Select other option in Journal of publication. The additional text field will not appear.
  • Click other option again. This time the additional text field will appear.

Similar, unexpected, behaviour is presented during deselecting other option:

  • select/click different option in Journal of publication field. The visible text area will not disappear.
  • click different option again. This time the text area box will disappear.

Related information

This is was first reported in #219 and #245. It affect MacOS Chrome browser (Version 71.0.3578.98).

Resolution Note

Other options fields behaves correctly. The issues is only present in the Journal of publication field.

Brief check of relevant JS code doesn't show anything different from other relevant code for reset of the fields.

Contributor guide

Research direction
Inspect the JavaScript event handler for the journal of publication field to identify why the toggle only works on the second click. Check the event binding and the conditional logic that shows/hides the additional text area.
Tech stack
rubyjavascript
Domain
full stack
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75