diesel-rs/diesel

MySQL: Figure out how to handle tests that modify schema

Open

#661 opened on Feb 9, 2017

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)Rust (1,003 forks)batch import
help wantedmysql

Repository metrics

Stars
 (12,054 stars)
PR merge metrics
 (PR metrics pending)

Description

Our test suite for Postgres and SQLite assumes we can modify the db schema inside a transaction. This does not work on MySQL (it commits the transaction when you try to modify the schema).

We need to figure out a way to have those tests run on MySQL without introducing a bunch of overhead.

(To find affected tests, grep for FIXME: Figure out how to handle tests that modify schema)

Contributor guide

Research direction
Search for the FIXME comment in the test suite, analyze the affected tests, and research how MySQL handles DDL statements in transactions. Consider alternatives like running schema changes outside transactions, using separate schemas, or using tools like database migrations before tests. Explore how other Rust ORMs handle this problem.
Tech stack
mysqlrust
Domain
backenddatabasetesting
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50