diegomura/react-pdf

Type error when render children inside Svg component

Open

#2,235 opened on Mar 9, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (1,116 forks)batch import
help wanted

Repository metrics

Stars
 (13,687 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Property 'children' does not exist on type 'IntrinsicAttributes & IntrinsicClassAttributes & Readonly I want to render svg, and got this error with types

Expected behavior Expect to solve the problem with type

Screenshots

Desktop (please complete the following information):

  • OS: MacOS
  • Browser chrome 110
  • React-pdf version ^3.0.0
  • React version ^18.0.0

Contributor guide

Research direction
The issue is a type error in the Svg component's type definition. Investigate the Svg component in the react pdf source code, likely in the type definitions file (e.g., `src/index.d.ts` or similar). Check if the `children` prop is missing from the SvgProps interface. The fix would be to add `children?: React.ReactNode` to the SvgProps interface. No linked PRs or comments indicating blockers.
Tech stack
reacttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
TypeScript type definitionsReact component props
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70