dice-roller/rpg-dice-roller

Support ternary operator

Open

#240 opened on Jan 17, 2022

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)JavaScript (68 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (279 stars)
PR merge metrics
 (PR metrics pending)

Description

Is your feature request related to a problem? Please describe. In the tool I'm writing currently I use mustache for user side templating and this lib to "evaluate" the values. For some expression it would be easier and cleaner to write and use them if this lib would support ternary operations.

Describe the solution you'd like Support writing a ? b : c which returns b if a is non-zero and c if a is zero. With this the comparison operators should also work with just naked numbers so that the following expression would also work 1>0 ? 100 : 0.

Describe alternatives you've considered I can always write my own parser on top of this lib and I might have to do that at some point anyways. 😅

Contributor guide

Research direction
Examine the current expression parser to understand how binary operators are handled and extend it to support ternary operators (a ? b : c). Ensure comparisons work with naked numbers like 1>0.
Tech stack
javascript
Domain
tooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptExpression parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60