deniscerri/ytdlnis

Implement download dialog

Closed

#441 opened on Mar 29, 2024

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)Kotlin (433 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (9,715 stars)
PR merge metrics
 (Avg merge 3d 22h) (4 merged PRs in 30d)

Description

Is your feature request available in yt-dlp? Please describe. I'm always frustrated whenI click the download button on YouTube ReVanced and the app goes to PiP mode[...]

Describe the solution you'd like Cause the download window to be invoked without enabling PiP in YouTube ReVanced.

Describe alternatives you've considered With NewPipe I can download without activating YouTube ReVanced's PiP mode.

Additional context Thanks for your great work. 🙏🏽 Screenshot_20240328-204941

Contributor guide

Research direction
Investigate how the download button currently triggers PiP mode and separate the download dialog invocation. Look at the existing code for handling download actions and PiP transitions.
Tech stack
kotlin
Domain
mobile
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Android developmentKotlin
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70