delta-io/delta

[Kernel] [TODO] Assert that log files belong to the table

Closed

#1,968 opened on Aug 9, 2023

View on GitHubContributor guide
 (4 comments) (0 reactions) (0 assignees)Scala (2,153 forks)batch import
enhancementgood first issuekernelstale

Repository metrics

Stars
 (8,939 stars)
PR merge metrics
 (Avg merge 7d 1h) (142 merged PRs in 30d)

Description

Complete the below TODO.

/**
 * Verifies that a set of delta or checkpoint files to be read actually belongs to this table.
 */
private void assertLogFilesBelongToTable(Path logPath, Stream<FileStatus> allFiles) {
    // TODO:
}

https://github.com/delta-io/delta/blob/efa566fc24af0b2c65b08c2a7ad81e9c865e0e83/kernel/kernel-api/src/main/java/io/delta/kernel/internal/replay/LogReplay.java#L158

Contributor guide

Research direction
Implement the method assertLogFilesBelongToTable by checking that the log files' paths match the expected table path pattern. Examine how table paths are structured and use the file system to validate that each file is within the table directory.
Tech stack
java
Domain
database
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70