dbt-labs/schemas.getdbt.com

Ensure newline characters a then end of `.json` files are removed

Open

#81 opened on Feb 4, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)HTML (1 fork)auto 404
enhancementgood first issuetech_debt

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

In dbt-core we have a pre-commit hook which removes newline characters at the end of json files. We don't have that in schemas.getdbt.com. This sometimes means that a newline character exists in schemas.getdbt.com's version of jsonschema files, while core's never do. This causes a problem because in core we do a strict artifact comparison check to make sure things match. To resolve this, we should start enforcing the removal of newline characters in this repository.

Contributor guide

Research direction
Add a pre commit hook to remove trailing newlines from JSON files in the repository.
Tech stack
None
Domain
backend
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gitpre commit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80