davidtheclark/react-aria-modal

[feature] When modal is rendered into a certain node, `esc` should close the modal when it's pressed within that node

Open

#62 opened on Mar 28, 2018

View on GitHub
 (7 comments) (0 reactions) (0 assignees)JavaScript (94 forks)github user discovery
enhancementhelp wanted

Repository metrics

Stars
 (1,039 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This might be optional behavior. Perhaps even a separate option altogether.

Something like a rootNode prop, maybe?

Contributor guide

Research direction
Explore implementing a `rootNode` prop that restricts the ESC close behavior to when focus is within that node.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Needs investigation
Prerequisites
React
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65