daphne-project/daphne

Rewrite CanonicalizationConstantFoldingOpTest

Open

#990 opened on Nov 18, 2025

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (84 forks)auto 404
Testsgood first issue

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

The CanonicalizationConstantFoldingOpTest is currently checking if a hardcoded ir matches the system output. As the reference ir has to be updated every time the system produces an even slightly different ir, this is not maintainable.

llvm-lit provides a testing architecture to solve this. See the documentation. We also already use lit tests, see here.

The current CanonicalizationConstantFoldingOpTest should be rewritten as a lit test.

Contributor guide

Research direction
Examine existing lit tests in the repository (e.g., test/util) to understand the pattern, then rewrite CanonicalizationConstantFoldingOpTest as a lit test by moving the test logic into a .mlir file and using the lit framework.
Tech stack
cpp
Domain
compilers
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75