daphne-project/daphne

Formatting in tests

Open

#849 opened on Oct 12, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (84 forks)auto 404
Testsgood first issue

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

Since we added the .clang-format file, some of the tests that were formatted look a bit off now. For example, the brace initialized std::vector here are no longer formatted as a 4x6 matrix.

One possible solution is to check out the clang-format settings and figure out if there's a setting that works for our test code.

https://clang.llvm.org/docs/ClangFormatStyleOptions.html

Another one would be to put // clang-format [off | on] around such sections we do not want to have formatted.

Contributor guide

Research direction
Review the current .clang format configuration and test the effect of different options on the specific test file. Alternatively, propose adding clang format off/on comments around the matrix initializations.
Tech stack
cpp
Domain
developer experience
Issue type
Chore
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80