daphne-project/daphne

`CSRMatrix::append()` on empty matrix

Open

#727 opened on May 16, 2024

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C++ (84 forks)auto 404
buggood first issue

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

The current implementation of the append mechanism of CSRMatrix (prepareAppend(), append(), finishAppend()) seems to be incorrect when the number of rows and/or the number of columns of the matrix is zero.

A similar problem existed for DenseMatrix and was fixed in 2b4f086ce45df10419c00d05e56433c30999a91a.

Thanks to @AlexRTer for pointing out this problem in #722.

Contributor guide

Research direction
Examine the fix for DenseMatrix::append() in commit 2b4f086 and apply similar changes to CSRMatrix::append() to handle zero rows or columns.
Tech stack
cpp
Domain
backenddata
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60