daphne-project/daphne

Kernel specialization of EwBinaryObjSca for DenseMatrix,double and double scalar multiplication

Open

#346 opened on Apr 29, 2022

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C++ (84 forks)auto 404
good first issue

Repository metrics

Stars
 (80 stars)
PR merge metrics
 (PR metrics pending)

Description

Currently EwBinaryObjSca-kernel supports element-wise multiplications between dense matrices and scalars of the same value type (DenseMatrix<double> * double, DenseMatrix<int> * int). We need to support this operation between different value types as well. This will allow us to run more scripts like scripts/lmDS.daph, which requires an element-wise multiplication between DenseMatrix<double> and an int.

We need to specialize kernel EwBinaryObjSca for DenseMatrix<double> * int. The result should be a DenseMatrix<double> matrix.

This issue asks you to implement

  1. A partial specialization of the EwBinaryObjSca-kernel for DenseMatrix<double> * int64_t (result DenseMatrix<double>).
  2. Ideally some test cases in test/runtime/local/kernels/EwBinaryObjScaTest.cpp
  3. Optionally, partial specilization for DenseMatrix<int64_t> * double (result DenseMatrix<double>).

Contributor guide

Research direction
Study the existing EwBinaryObjSca kernel template implementation for scalar matrix multiplication. Identify the base template and add a partial specialization for the case where left operand is DenseMatrix<double> and right operand is int64 t, returning DenseMatrix<double>. Then add test cases in the corresponding test file. Optionally, also implement specialization for DenseMatrix<int64 t> * double.
Tech stack
ccpp
Domain
backenddatabase
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++GitTemplate Metaprogramming
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55