daniele-liprandi/EvoNEST-backbone

Missing ObjectId validation

Open

#33 opened on Nov 26, 2025

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)JavaScript (2 forks)auto 404
BackendHighbuggood first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

Description

ObjectIds from user input are passed directly to MongoDB operations without validation, causing poor error messages when invalid.

Files affected

  • Multiple API routes

Current code

const result = await users.updateOne(
    { _id: new ObjectId(data.id) },  // No validation
);

Recommended fix

Create a utility function to validate ObjectIds before use.

Contributor guide

Research direction
Create a utility function validateObjectId that checks if the input is a valid ObjectId string. Then replace all direct uses of `new ObjectId(data.id)` with a call to this function to ensure proper error handling. Also, consider adding unit tests for the validation function.
Tech stack
javascriptnodejsmongodb
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80