conductor-oss/conductor

APIs throwing 500 status when 4** is expected

Open

#172 opened on May 28, 2024

View on GitHub
 (7 comments) (0 reactions) (2 assignees)Java (894 forks)batch import
bughelp wanted

Repository metrics

Stars
 (31,816 stars)
PR merge metrics
 (Avg merge 7d 14h) (34 merged PRs in 30d)

Description

Describe the bug When trying to delete a non-existing workflow using DELETE {{conductorBaseUrl}}/api/metadata/workflow/:name/:version api replies back with 500 status code.

{
    "status": 500,
    "message": "No such workflow definition: memes_maker version: 2",
    "instance": "1a79daf01f84",
    "retryable": false
}

Details Conductor version: v3.19.0 Persistence implementation: Postgres Queue implementation: Postgres Lock: I guess redis

To Reproduce Steps to reproduce the behavior:

  1. Use API to delete non existing workflow
curl --location --request DELETE 'http://localhost8080/api/metadata/workflow/memes_maker/2'
  1. See error

Expected behavior Status code should be 404

Additional context Same thing happens if we try to create existing workflow with existing version.

Contributor guide

Research direction
Inspect the delete workflow endpoint handler and ensure it returns 404 when workflow is not found.
Tech stack
java
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaREST APIs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75