codex-team/editor.js

[Bug] Polyfill promise conflict

Open

#1,634 opened on Apr 8, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (1,985 forks)batch import
buggood first issue

Repository metrics

Stars
 (26,602 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

This package seems to polyfill window.Promise, regardless of whether window.Promise already exists. This is causing problems as we are using and relying on our own polyfill (bluebird.js), but this is being replaced if I call new EditorJS().

Contributor guide

Research direction
Check the polyfill implementation in the codebase. Look for where Promise is assigned to window.Promise and add a condition to skip if window.Promise already exists.
Tech stack
javascripttypescript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65