codenotary/immudb

Tests improvements: Better check for errors

Open

#1,435 opened on Oct 26, 2022

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)Go (371 forks)auto 404
enhancementgood first issue

Repository metrics

Stars
 (8,999 stars)
PR merge metrics
 (PR metrics pending)

Description

What would you like to be added or enhanced

In many tests we're using require.Error(t, err) which only checks if the error happened without checking if the error is actually expected.

We should add more detailed error check, either by using require.ErrorIs or require.ErrorContains assertions.

Why is this needed

When expecting an error it is necessary to ensure the returned error is what was expected. It may turn out that in some cases the error checked by the test is not what it should be.

Contributor guide

Research direction
Search test files for require.Error(t, err) calls and replace each with a more specific assertion, such as require.ErrorIs or require.ErrorContains, based on the expected error message or type.
Tech stack
go
Domain
databasebackend
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Gotesting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90