codeigniter4/CodeIgniter4

Dev: PHPStan "no value type specified in iterable type array" errors

Open

#8,732 opened on Apr 9, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)PHP (1,707 forks)batch import
devgood first issuehelp wanted

Repository metrics

Stars
 (4,492 stars)
PR merge metrics
 (Avg merge 3d 13h) (67 merged PRs in 30d)

Description

There are 1,763 ignored errors due to "no value type specified in iterable type array" in phpstan-baseline.php. These ignored errors should be removed.

You can search for no value type specified in iterable type array in phpstan-baseline.php.

$ grep "no value type specified in iterable type array" phpstan-baseline.php | wc -l
    1763

Contributor guide

Research direction
Look at the phpstan baseline.php file in the repository root. Search for all lines containing 'no value type specified in iterable type array'. For each occurrence, identify the corresponding source file and method/function that needs a type annotation (e.g., add @param array<KeyType, ValueType> or @return array<...>). After adding proper type hints to the PHP code, remove the ignored error line from the baseline. Repeat for all 1763 occurrences. Refer to PHPStan documentation for correct generic array syntax. If uncertain, check existing similar fixes in the codebase for patterns.
Tech stack
php
Domain
backendtoolingdeveloper experience
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPPHPStan basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45