codeigniter4/CodeIgniter4

Dev: replace type `mixed` with more specific types

Closed

#6,310 opened on Jul 29, 2022

View on GitHubContributor guide
 (11 comments) (0 reactions) (0 assignees)PHP (1,707 forks)batch import
devgood first issuehelp wanted

Repository metrics

Stars
 (4,492 stars)
PR merge metrics
 (Avg merge 4d 15h) (68 merged PRs in 30d)

Description

Type mixed means object|resource|array|string|int|float|bool|null. https://www.php.net/manual/en/language.types.declarations.php#language.types.declarations.mixed

The current code base has a lot of type mixed in PHPDocs, But I think all of them are not correct.

And mixed prevents PHPStan level from increasing.

PHPStan’s rule level 6 isn’t satisfied with implicit mixed https://phpstan.org/writing-php-code/phpdoc-types#mixed

We need to replace type mixed with more specific types.

Contributor guide

Research direction
Search for all `mixed` type hints in PHPDocs across the codebase and determine the correct specific type for each based on context (e.g., parameter usage, return values).
Tech stack
php
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPPHPDoc
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70