code4romania/covid-19-jurnal-medical

Sending daily emails to users can be stopped

Open

#432 opened on May 22, 2020

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)C# (50 forks)auto 404
apibughelp wanted

Repository metrics

Stars
 (14 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

By using the https://prod-api.stamacasa.ro/api/profile/family/ IDOR an attacker is able to stop all users from receiving daily emails, as they are only sent to users without the ParentId set.

backend/src/StamAcasa.Common/Notifications/AssessmentNotificationsDispatch.cs

Contributor guide

Research direction
Examine the IDOR vulnerability in the family API endpoint and the notification dispatch logic. Check how ParentId is set and ensure authorization checks prevent unauthorized users from modifying it.
Tech stack
csharp
Domain
backendsecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
C#Web security basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70