cmu-delphi/delphi-epidata

clean up insert_or_update_batch() method

Open

#989 opened on Oct 4, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Python (67 forks)auto 404
acquisitioncode healthgood first issuehelp wantedrefactor

Repository metrics

Stars
 (104 stars)
PR merge metrics
 (PR metrics pending)

Description

  • remove insert_or_update_bulk()
  • roll run_dbjobs() logic into the insert_batch method
    • can get rid of "suppress_jobs" argument too, unless someone can come up with a good reason for keeping it

https://github.com/cmu-delphi/delphi-epidata/blob/dev/src/acquisition/covidcast/database.py#L159

Contributor guide

Research direction
Inspect the linked source file (src/acquisition/covidcast/database.py) to understand the current insert or update batch() method and the related insert or update bulk() and run dbjobs() functions. Then remove insert or update bulk() and integrate the logic of run dbjobs() into insert batch, handling the 'suppress jobs' argument appropriately.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75