cmu-delphi/delphi-epidata

Update `test_covidcast_meta.py` with hard value comparisons

Open

#924 opened on Jun 2, 2022

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (67 forks)auto 404
help wanted

Repository metrics

Stars
 (104 stars)
PR merge metrics
 (PR metrics pending)

Description

just want to point out that nothing in these tests is actually testing that the meta values were computed correctly, only that the length of the responses returned was correct and that fields like min_time are present. i don't believe that the changes to compute_covidcast_meta warrant and update to that, but it would be good to have at least a few tests that compare hard values in the future.

Originally posted by @dshemetov in https://github.com/cmu-delphi/delphi-epidata/pull/903#discussion_r887367780

Related: #897

Contributor guide

Research direction
Study the existing test covidcast meta.py to understand the structure, then identify key meta values that can be hardcoded and asserted against the actual output of compute covidcast meta.
Tech stack
python
Domain
backendapidata
Issue type
Test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Pythonpytest
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70