cjoudrey/graphql-schema-linter

Non-null Int types for "first" argument are not accepted by rule "relay-connection-arguments-spec"

Open

#148 opened on Sep 7, 2018

View on GitHubContributor guide
 (3 comments) (0 reactions) (0 assignees)JavaScript (61 forks)batch import
enhancementhelp wanted

Repository metrics

Stars
 (704 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The following queries all fail lint checks:

  notablePeople(first: Int!, after: ID): NotablePersonConnection!

  users(first: Int!, after: ID, where: UsersQueryWhereInput): UserConnection!
    @requireOneOfRoles(roles: [MODERATOR])

  notablePeopleEvents(
    first: Int!
    after: ID
    where: NotablePersonEventsQueryWhereInput
  ): NotablePersonEventConnection!

If I remove the !, they all pass. Should not non-null integer types be accepted?

Contributor guide

Research direction
Find the validation rule 'relay connection arguments spec' and update its logic to accept non null Int types for the 'first' argument.
Tech stack
javascriptgraphql
Domain
api
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GraphQLJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70